Refactor Runner parameter overloads and resolve review comments#2210
Refactor Runner parameter overloads and resolve review comments#2210rafal-hawrylak wants to merge 1 commit into
Conversation
rafal-hawrylak
requested review from
Ceridan
and removed request for
a team and
Ceridan
rafal-hawrylak
force-pushed
the
pr4b-refactor-runner
branch
from
5811b99 to
d836784
Compare
rafal-hawrylak
force-pushed
the
pr4b-refactor-runner
branch
3 times, most recently
from
7df9bd9 to
edb1e7d
Compare
| } | ||
|
|
||
| export interface IExecutionOptions { | ||
| projectDir?: string; |
There was a problem hiding this comment.
Is this projectDir used downstream in latter PRs?
There was a problem hiding this comment.
Looking at this PR I can see that we are adding this field here, and then we are setting it (under some conditions to "."), but I am not sure how it is used. Possibly it is needed latter.
I can guess what this field does in general by the name, but is it needed?
There was a problem hiding this comment.
Yes, this is needed in the next PR - #2211. It is passed as the second arg to jitCompiler (via JitCompileChildProcess.compile) — it's the resolution root the worker needs to locate the caller's @dataform/core install. Plumbing it in here is the way to reduce the size of the next PR and still keep the reasonable amount of PRs.
There was a problem hiding this comment.
Yes, this is needed in the next PR — #2211. It is passed as the second arg to jitCompiler (via JitCompileChildProcess.compile) — it is the resolution root the worker needs to locate the caller's @dataform/core install. Plumbing it in here is the way to reduce the size of the next PR and still keep the reasonable amount of PRs.
rafal-hawrylak
force-pushed
the
pr4b-refactor-runner
branch
from
edb1e7d to
b668ebf
Compare
rafal-hawrylak
force-pushed
the
pr4b-refactor-runner
branch
from
b668ebf to
6cd64c1
Compare
2 participants
Pre follow up of #2184